Fix-81729 Preserve case in Search and Replace isn't working when I use group substitution #81858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roblourens , Any updates on this ? |
roblourens
reviewed
Oct 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roblourens , This was not touched upon when preserve case was implemented , I have changed it to make it work for group substitution also . The gist of the change is that instead of returning
text.replace(this._regExp, this.pattern);we returntext.replace(this._regExp, this.buildReplaceString(match, preserveCase));NOTE : I have changed test methods to the standard used in other functions to make it look cleaner as this was getting pretty messy , and existing test methods would cover this fix test cases
#81729